Transaction fixes and Client API (atop new quoting) #2522
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
autonomi/src/client/quote.rs
Outdated
| let mut rate_limiter = RateLimiter::new(); | ||
|
|
||
| for (content_addr, raw_quotes) in raw_quotes_per_addr { | ||
| // FIXME: find better way to deal with paid content addrs and feedback to the user |
Check notice
Code scanning / devskim
A "TODO" or similar was left in source code, possibly indicating incomplete functionality Note
| let metrics: Vec<_> = metrics.into_iter().map(|v| v.into()).collect(); | ||
| let mut amounts = self.contract.getQuote(metrics.clone()).call().await?.prices; | ||
|
|
||
| // FIXME: temporary logic until the smart contract gets updated |
Check notice
Code scanning / devskim
A "TODO" or similar was left in source code, possibly indicating incomplete functionality Note
| let payment_verification_results = payment_vault.verify_payment(payment_verifications).await?; | ||
|
|
||
| for payment_verification_result in payment_verification_results { | ||
| // TODO we currently fail on a single invalid payment, maybe we should deal with this in a different way |
Check notice
Code scanning / devskim
A "TODO" or similar was left in source code, possibly indicating incomplete functionality Note
grumbach
force-pushed
the
feat-transaction-client-api-atop-new-quoting
branch
2 times, most recently
from
6a4753f to
51a513f
Compare
grumbach
changed the title
maqi
force-pushed
the
feat-transaction-client-api-atop-new-quoting
branch
from
88a5e27 to
e4270aa
Compare
maqi
force-pushed
the
feat-transaction-client-api-atop-new-quoting
branch
from
bc84302 to
343a22d
Compare
maqi
approved these changes
Dec 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
MERGE AFTER the QUOTING WORK #2519
This PR is based on top of and replaces #2518